From: Andres Freund <andres@anarazel.de>
Date: Sun, 24 Dec 2017 10:57:55 +0000 (-0800)
Subject: Fix assert with side effects in the new PHJ code.
X-Git-Tag: REL_11_BETA1~1037
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4e2970f8807f1ccfc8029979a70dc80ee102ce48;p=thirdparty%2Fpostgresql.git

Fix assert with side effects in the new PHJ code.

Instead of asserting the assert just set the value to what it was
supposed to test...

Per coverity.
---

diff --git a/src/backend/executor/nodeHash.c b/src/backend/executor/nodeHash.c
index 4284e8682a0..0a519fae313 100644
--- a/src/backend/executor/nodeHash.c
+++ b/src/backend/executor/nodeHash.c
@@ -1275,7 +1275,7 @@ ExecParallelHashRepartitionFirst(HashJoinTable hashtable)
 	dsa_pointer chunk_shared;
 	HashMemoryChunk chunk;
 
-	Assert(hashtable->nbatch = hashtable->parallel_state->nbatch);
+	Assert(hashtable->nbatch == hashtable->parallel_state->nbatch);
 
 	while ((chunk = ExecParallelHashPopChunkQueue(hashtable, &chunk_shared)))
 	{