From: Hyunchul Lee <hyc.lee@gmail.com>
Date: Fri, 29 Apr 2022 23:30:28 +0000 (+0900)
Subject: ksmbd: smbd: change the return value of get_sg_list
X-Git-Tag: v5.19-rc1~78^2~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4e3edd0092704b25626a0fe60a974f6f382ff93d;p=thirdparty%2Fkernel%2Flinux.git

ksmbd: smbd: change the return value of get_sg_list

Make get_sg_list return EINVAL if there aren't
mapped scatterlists.

Signed-off-by: Hyunchul Lee <hyc.lee@gmail.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
---

diff --git a/fs/ksmbd/transport_rdma.c b/fs/ksmbd/transport_rdma.c
index 4372d631735e3..696ffd2ae6613 100644
--- a/fs/ksmbd/transport_rdma.c
+++ b/fs/ksmbd/transport_rdma.c
@@ -1079,7 +1079,7 @@ static int get_sg_list(void *buf, int size, struct scatterlist *sg_list, int nen
 	int offset, len;
 	int i = 0;
 
-	if (nentries < get_buf_page_count(buf, size))
+	if (size <= 0 || nentries < get_buf_page_count(buf, size))
 		return -EINVAL;
 
 	offset = offset_in_page(buf);
@@ -1111,7 +1111,7 @@ static int get_mapped_sg_list(struct ib_device *device, void *buf, int size,
 	int npages;
 
 	npages = get_sg_list(buf, size, sg_list, nentries);
-	if (npages <= 0)
+	if (npages < 0)
 		return -EINVAL;
 	return ib_dma_map_sg(device, sg_list, npages, dir);
 }