From: Marcel Holtmann <marcel@holtmann.org>
Date: Wed, 24 Apr 2019 20:18:53 +0000 (+0200)
Subject: genetlink: use idr_alloc_cyclic for family->id assignment
X-Git-Tag: v5.1~11^2~29
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4e43df38a2e6c876d3c8ecc4196ed67a895c425d;p=thirdparty%2Flinux.git

genetlink: use idr_alloc_cyclic for family->id assignment

When allocating the next family->id it makes more sense to use
idr_alloc_cyclic to avoid re-using a previously used family->id as much
as possible.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c
index f0ec068e1d02f..cb69d35c8e6ad 100644
--- a/net/netlink/genetlink.c
+++ b/net/netlink/genetlink.c
@@ -362,8 +362,8 @@ int genl_register_family(struct genl_family *family)
 	} else
 		family->attrbuf = NULL;
 
-	family->id = idr_alloc(&genl_fam_idr, family,
-			       start, end + 1, GFP_KERNEL);
+	family->id = idr_alloc_cyclic(&genl_fam_idr, family,
+				      start, end + 1, GFP_KERNEL);
 	if (family->id < 0) {
 		err = family->id;
 		goto errout_free;