From: Fenglin Wu <fenglinw@codeaurora.org>
Date: Wed, 19 Jul 2017 06:39:55 +0000 (+0800)
Subject: pinctrl: qcom: spmi-gpio: Correct power_source range check
X-Git-Tag: v4.14-rc1~142^2~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4e83ac4cfbde6b300f31f9460b96c67664a792ce;p=thirdparty%2Fkernel%2Flinux.git

pinctrl: qcom: spmi-gpio: Correct power_source range check

Power source selection in DIG_VIN_CTL is indexed from 0, in the range
check it shouldn't be equal to the total number of power sources.

Signed-off-by: Fenglin Wu <fenglinw@codeaurora.org>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---

diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index 73ce2b5cf9a38..c2c0bab04257d 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -487,7 +487,7 @@ static int pmic_gpio_config_set(struct pinctrl_dev *pctldev, unsigned int pin,
 			pad->is_enabled = false;
 			break;
 		case PIN_CONFIG_POWER_SOURCE:
-			if (arg > pad->num_sources)
+			if (arg >= pad->num_sources)
 				return -EINVAL;
 			pad->power_source = arg;
 			break;