From: Michael Tremer <michael.tremer@ipfire.org>
Date: Tue, 3 Jun 2025 10:33:44 +0000 (+0200)
Subject: ovpnmain.cgi: Remove some dead code
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4eb385c392f2349739e655754ba8b67d82688e21;p=people%2Fms%2Fipfire-2.x.git

ovpnmain.cgi: Remove some dead code

This prevented creating new connections and was never being used at all.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
index 4dc4eebdf..a7bc0c02a 100644
--- a/html/cgi-bin/ovpnmain.cgi
+++ b/html/cgi-bin/ovpnmain.cgi
@@ -4053,10 +4053,6 @@ if ($cgiparams{'TYPE'} eq 'net') {
 	    $errormessage = $Lang::tr{'invalid input'};
 	    goto VPNCONF_ERROR;
 	}
-	if ($cgiparams{'EDIT_ADVANCED'} !~ /^(on|off)$/) {
-	    $errormessage = $Lang::tr{'invalid input'};
-	    goto VPNCONF_ERROR;
-	}
 
 	if ($cgiparams{'AUTH'} eq 'certreq') {
 	    if ($cgiparams{'KEY'}) {
@@ -4445,10 +4441,6 @@ if ($cgiparams{'TYPE'} eq 'net') {
 		}
 	}
 
-	if ($cgiparams{'EDIT_ADVANCED'} eq 'on') {
-	    $cgiparams{'KEY'} = $key;
-	    $cgiparams{'ACTION'} = $Lang::tr{'advanced'};
-	}
 	goto VPNCONF_END;
     } else {
         $cgiparams{'ENABLED'} = 'on';
@@ -4478,10 +4470,6 @@ if ($cgiparams{'TYPE'} eq 'net') {
 
 	$checked{'OTP_STATE'}{$cgiparams{'OTP_STATE'}} = 'CHECKED';
 
-    $checked{'EDIT_ADVANCED'}{'off'} = '';
-    $checked{'EDIT_ADVANCED'}{'on'} = '';
-    $checked{'EDIT_ADVANCED'}{$cgiparams{'EDIT_ADVANCED'}} = 'CHECKED';
-
     $selected{'SIDE'}{'server'} = '';
     $selected{'SIDE'}{'client'} = '';
     $selected{'SIDE'}{$cgiparams{'SIDE'}} = 'SELECTED';