From: Vitaly Kuznetsov Date: Fri, 28 Jan 2022 10:34:12 +0000 (+0100) Subject: Drivers: hv: Compare cpumasks and not their weights in init_vp_index() X-Git-Tag: v5.18-rc1~138^2~4 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4ee524587105011ef43e5bd3ef5ed019715363dd;p=thirdparty%2Fkernel%2Flinux.git Drivers: hv: Compare cpumasks and not their weights in init_vp_index() The condition is supposed to check whether 'allocated_mask' got fully exhausted, i.e. there's no free CPU on the NUMA node left so we have to use one of the already used CPUs. As only bits which correspond to CPUs from 'cpumask_of_node(numa_node)' get set in 'allocated_mask', checking for the equal weights is technically correct but not obvious. Let's compare cpumasks directly. No functional change intended. Suggested-by: Michael Kelley Signed-off-by: Vitaly Kuznetsov Reviewed-by: Michael Kelley Link: https://lore.kernel.org/r/20220128103412.3033736-3-vkuznets@redhat.com Signed-off-by: Wei Liu --- diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c index 52cf6ae525e96..26d269ba947c8 100644 --- a/drivers/hv/channel_mgmt.c +++ b/drivers/hv/channel_mgmt.c @@ -762,8 +762,7 @@ static void init_vp_index(struct vmbus_channel *channel) } allocated_mask = &hv_context.hv_numa_map[numa_node]; - if (cpumask_weight(allocated_mask) == - cpumask_weight(cpumask_of_node(numa_node))) { + if (cpumask_equal(allocated_mask, cpumask_of_node(numa_node))) { /* * We have cycled through all the CPUs in the node; * reset the allocated map.