From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 26 Jan 2005 21:24:27 +0000 (+0000)
Subject: Minor tweak to avoid unnecessary memory bloat when dumping extremely wide
X-Git-Tag: REL8_0_1~24
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4f6bd8a998c7656da29bb923a5eda25cd3670225;p=thirdparty%2Fpostgresql.git

Minor tweak to avoid unnecessary memory bloat when dumping extremely wide
column values in -d mode.  Per report from Marty Scholes.  This doesn't
completely solve the issue, because we still need multiple copies of the
field value, but at least one copy can be got rid of painlessly ...
---

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index f5a392ab2bf..d28e235e619 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -12,7 +12,7 @@
  *	by PostgreSQL
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.400.4.1 2005/01/23 00:31:46 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.400.4.2 2005/01/26 21:24:27 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -985,7 +985,7 @@ dumpTableData_insert(Archive *fout, void *dcontext)
 					appendPQExpBuffer(q, fmtId(PQfname(res, field)));
 				}
 				appendPQExpBuffer(q, ") ");
-				archprintf(fout, "%s", q->data);
+				archputs(q->data, fout);
 			}
 			archprintf(fout, "VALUES (");
 			for (field = 0; field < nfields; field++)
@@ -1047,7 +1047,7 @@ dumpTableData_insert(Archive *fout, void *dcontext)
 						/* All other types are printed as string literals. */
 						resetPQExpBuffer(q);
 						appendStringLiteral(q, PQgetvalue(res, tuple, field), false);
-						archprintf(fout, "%s", q->data);
+						archputs(q->data, fout);
 						break;
 				}
 			}