From: Sami Kerola <kerolasa@iki.fi>
Date: Sat, 18 May 2019 21:09:25 +0000 (+0100)
Subject: lib/mangle: fix possible null pointer dereference [cppcheck]
X-Git-Tag: v2.34-rc2~51^2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4f807791eee8ead3f38f1dce76f748fa0773f9a6;p=thirdparty%2Futil-linux.git

lib/mangle: fix possible null pointer dereference [cppcheck]

Fix effects code that is used when testing util-linux, so quite low impact.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---

diff --git a/lib/mangle.c b/lib/mangle.c
index b514cd8d35..87802fbda0 100644
--- a/lib/mangle.c
+++ b/lib/mangle.c
@@ -155,9 +155,9 @@ int main(int argc, char *argv[])
 		}
 
 		x = strdup(argv[2]);
-		unmangle_to_buffer(x, x, strlen(x) + 1);
-
 		if (x) {
+			unmangle_to_buffer(x, x, strlen(x) + 1);
+
 			printf("self-unmangled: '%s'\n", x);
 			free(x);
 		}