From: Christian Brauner <brauner@kernel.org>
Date: Mon, 25 Nov 2024 14:10:24 +0000 (+0100)
Subject: nfsd: avoid pointless cred reference count bump
X-Git-Tag: v6.14-rc1~214^2~1^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4fa6af563d4dcef43ae34a9bce9d1a9440f20867;p=thirdparty%2Fkernel%2Flinux.git

nfsd: avoid pointless cred reference count bump

The code already got rid of the extra reference count from the old
version of override_creds().

Link: https://lore.kernel.org/r/20241125-work-cred-v2-28-68b9d38bb5b2@kernel.org
Acked-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Christian Brauner <brauner@kernel.org>
---

diff --git a/fs/nfsd/auth.c b/fs/nfsd/auth.c
index c399a5f030afb..4dc327e024567 100644
--- a/fs/nfsd/auth.c
+++ b/fs/nfsd/auth.c
@@ -79,8 +79,7 @@ int nfsd_setuser(struct svc_cred *cred, struct svc_export *exp)
 	else
 		new->cap_effective = cap_raise_nfsd_set(new->cap_effective,
 							new->cap_permitted);
-	put_cred(override_creds(get_new_cred(new)));
-	put_cred(new);
+	put_cred(override_creds(new));
 	return 0;
 
 oom: