From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Thu, 15 Sep 2022 12:46:30 +0000 (+0200)
Subject: document jq/jo tradeoff
X-Git-Tag: rec-4.9.0-alpha0~5^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4fd2c1d5df12fb431c29f2056d7c60d7e840cbe8;p=thirdparty%2Fpdns.git

document jq/jo tradeoff
---

diff --git a/.github/workflows/builder-dispatch.yml b/.github/workflows/builder-dispatch.yml
index 16e14bbd75..0e6db3924d 100644
--- a/.github/workflows/builder-dispatch.yml
+++ b/.github/workflows/builder-dispatch.yml
@@ -41,6 +41,9 @@ jobs:
     outputs:
       oslist: ${{ steps.get-oslist.outputs.oslist }}
     steps:
+      # instead of jo, we could use jq here, which avoids running apt, and thus would be faster.
+      # but, as this whole workflow needs at least 30 minutes to run, I prefer spending a few seconds here
+      # so that the command remains readable, because jo is simpler to use.
       - run: sudo apt-get update && sudo apt-get -y install jo
       - id: get-oslist
         run: echo "::set-output name=oslist::"$(jo -a ${{ github.event.inputs.os }})