From: Daniel P. Berrangé <berrange@redhat.com>
Date: Mon, 15 Jan 2024 09:51:19 +0000 (+0000)
Subject: ui: reject extended clipboard message if not activated
X-Git-Tag: v8.2.2~29
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4fd56da3370a7ad009a0a960e722991c9927d890;p=thirdparty%2Fqemu.git

ui: reject extended clipboard message if not activated

The extended clipboard message protocol requires that the client
activate the extension by requesting a psuedo encoding. If this
is not done, then any extended clipboard messages from the client
should be considered invalid and the client dropped.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20240115095119.654271-1-berrange@redhat.com>
(cherry picked from commit 4cba8388968b70fe20e290221dc421c717051fdd)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---

diff --git a/ui/vnc.c b/ui/vnc.c
index 4f23a0fa79f..3b2c71e6537 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -2445,6 +2445,11 @@ static int protocol_client_msg(VncState *vs, uint8_t *data, size_t len)
         }
 
         if (read_s32(data, 4) < 0) {
+            if (!vnc_has_feature(vs, VNC_FEATURE_CLIPBOARD_EXT)) {
+                error_report("vnc: extended clipboard message while disabled");
+                vnc_client_error(vs);
+                break;
+            }
             if (dlen < 4) {
                 error_report("vnc: malformed payload (header less than 4 bytes)"
                              " in extended clipboard pseudo-encoding.");