From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Wed, 22 Jan 2025 20:30:21 +0000 (+0200)
Subject: quota: Fix error handling if quota_warning settings couldn't be looked up
X-Git-Tag: 2.4.1~271
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4fea6b3bff0872335ca11e6e569d9757c5d5fe15;p=thirdparty%2Fdovecot%2Fcore.git

quota: Fix error handling if quota_warning settings couldn't be looked up

The error code path for some reason deinitialized the whole quota root,
which caused freed memory to be accessed later.
---

diff --git a/src/plugins/quota/quota.c b/src/plugins/quota/quota.c
index 5997f5f84b..81b10f50eb 100644
--- a/src/plugins/quota/quota.c
+++ b/src/plugins/quota/quota.c
@@ -174,7 +174,6 @@ static int quota_root_has_under_warnings(struct quota_root *root)
 					&quota_root_setting_parser_info, 0,
 					&set, &error) < 0) {
 			e_error(root->backend.event, "%s", error);
-			quota_root_deinit(root);
 			return -1;
 		}
 		bool under = strcmp(set->quota_warning_threshold,