From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 7 Aug 2023 04:46:18 +0000 (+1200)
Subject: s3:nmbd: Add missing newlines to logging messages
X-Git-Tag: tevent-0.16.0~1142
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4fef81f183fc403913fc52831db1cdbbcc76c0ae;p=thirdparty%2Fsamba.git

s3:nmbd: Add missing newlines to logging messages

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source3/nmbd/asyncdns.c b/source3/nmbd/asyncdns.c
index 7f37c401279..4601ba61559 100644
--- a/source3/nmbd/asyncdns.c
+++ b/source3/nmbd/asyncdns.c
@@ -322,7 +322,7 @@ bool queue_dns_query(struct packet_struct *p,struct nmb_name *question)
 
 	pull_ascii_nstring(qname, sizeof(qname), question->name);
 
-	DBG_NOTICE("DNS search for %s - ", nmb_namestr(question));
+	DBG_NOTICE("DNS search for %s -\n", nmb_namestr(question));
 
 	dns_ip.s_addr = interpret_addr(qname);
 
diff --git a/source3/nmbd/nmbd.c b/source3/nmbd/nmbd.c
index 7cdd9bd1303..f4ffad66c8b 100644
--- a/source3/nmbd/nmbd.c
+++ b/source3/nmbd/nmbd.c
@@ -116,7 +116,7 @@ static bool nmbd_setup_sig_term_handler(struct messaging_context *msg)
 			       nmbd_sig_term_handler,
 			       msg);
 	if (!se) {
-		DBG_ERR("failed to setup SIGTERM handler");
+		DBG_ERR("failed to setup SIGTERM handler\n");
 		return false;
 	}
 
@@ -179,7 +179,7 @@ static bool nmbd_setup_sig_hup_handler(struct messaging_context *msg)
 			       nmbd_sig_hup_handler,
 			       msg);
 	if (!se) {
-		DBG_ERR("failed to setup SIGHUP handler");
+		DBG_ERR("failed to setup SIGHUP handler\n");
 		return false;
 	}
 
@@ -721,7 +721,7 @@ static bool open_sockets(bool isdaemon, int port)
 	if (!interpret_string_addr(&ss, sock_addr,
 				AI_NUMERICHOST|AI_PASSIVE)) {
 		DBG_ERR("open_sockets: unable to get socket address "
-			"from string %s", sock_addr);
+			"from string %s\n", sock_addr);
 		return false;
 	}
 	if (ss.ss_family != AF_INET) {
diff --git a/source3/nmbd/nmbd_winsserver.c b/source3/nmbd/nmbd_winsserver.c
index 47ea7bee7e1..ecae4476195 100644
--- a/source3/nmbd/nmbd_winsserver.c
+++ b/source3/nmbd/nmbd_winsserver.c
@@ -1665,7 +1665,7 @@ IP %s\n", nmb_namestr(question), inet_ntoa(from_ip) ));
 
 	if(question->name_type == 0x1d) {
 		DEBUG(3,("wins_process_multihomed_name_registration_request: Ignoring request \
-to register name %s from IP %s.", nmb_namestr(question), inet_ntoa(p->ip) ));
+to register name %s from IP %s.\n", nmb_namestr(question), inet_ntoa(p->ip) ));
 		send_wins_name_registration_response(0, ttl, p);  
 		return;
 	}
@@ -2178,7 +2178,7 @@ IP %s\n", releasing_group_name ? "Group" : "Unique", nmb_namestr(question), inet
 
 	if(!releasing_group_name && (question->name_type == 0x1d)) {
 		DEBUG(3,("wins_process_name_release_request: Ignoring request \
-to release name %s from IP %s.", nmb_namestr(question), inet_ntoa(p->ip) ));
+to release name %s from IP %s.\n", nmb_namestr(question), inet_ntoa(p->ip) ));
 		send_wins_name_release_response(0, p);
 		return;
 	}