From: Fabian Frederick <fabf@skynet.be>
Date: Fri, 20 Feb 2015 18:12:55 +0000 (+0100)
Subject: hso: replace current->state by __set_current_state()
X-Git-Tag: v4.0-rc3~25^2~61
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=50462ce0052c67b5a06f19fb7c7f308813006879;p=thirdparty%2Fkernel%2Flinux.git

hso: replace current->state by __set_current_state()

Use helper functions to access current->state.
Direct assignments are prone to races and therefore buggy.

Thanks to Peter Zijlstra for the exact definition of the problem.

Suggested-By: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 9cdfb3fe9c156..778e91531fac7 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -1594,7 +1594,7 @@ hso_wait_modem_status(struct hso_serial *serial, unsigned long arg)
 		}
 		cprev = cnow;
 	}
-	current->state = TASK_RUNNING;
+	__set_current_state(TASK_RUNNING);
 	remove_wait_queue(&tiocmget->waitq, &wait);
 
 	return ret;