From: Mike Frysinger <vapier@gentoo.org>
Date: Tue, 9 Jan 2024 02:15:51 +0000 (-0500)
Subject: sim: igen: fix format-zero-length warnings
X-Git-Tag: binutils-2_42~175
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5048cb28f4a864d2426bcec8cb02f26ef3daac85;p=thirdparty%2Fbinutils-gdb.git

sim: igen: fix format-zero-length warnings

Fix warnings from calling printf functions with "" which normally
is useless.
---

diff --git a/sim/igen/gen.c b/sim/igen/gen.c
index 2176b603fc5..30cf1077033 100644
--- a/sim/igen/gen.c
+++ b/sim/igen/gen.c
@@ -67,7 +67,11 @@ print_gen_entry_path (const line_ref *line,
       if (table->top->model != NULL)
 	print (line, "%s", table->top->model->name);
       else
-	print (line, "");
+	{
+	  /* We don't want to output things, but we want the side-effects they
+	     might have (e.g. checking line != NULL).  */
+	  print (line, "%s", "");
+	}
     }
   else
     {
@@ -1242,7 +1246,7 @@ gen_entry_expand_insns (gen_entry *table)
 	  print_gen_entry_insns (table, warning,
 				 "was not uniquely decoded",
 				 "decodes to the same entry");
-	  error (NULL, "");
+	  error (NULL, "unrecoverable\n");
 	}
       return;
     }
@@ -1385,7 +1389,7 @@ gen_entry_expand_insns (gen_entry *table)
 		warning (NULL,
 			 ": Applying rule just copied all instructions\n");
 		print_gen_entry_insns (entry, warning, "Copied", NULL);
-		error (NULL, "");
+		error (NULL, "unrecoverable\n");
 	      }
 	  }
       }