From: Uwe Kleine-König Date: Fri, 10 Jun 2022 21:12:54 +0000 (+0200) Subject: mmc: dw_mmc: hi3789cv200: Obviously always return success in remove callback X-Git-Tag: v6.0-rc1~115^2~36 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=50699358222d004ad2b465c18b03d418b9b7fa90;p=thirdparty%2Flinux.git mmc: dw_mmc: hi3789cv200: Obviously always return success in remove callback dw_mci_pltfm_remove() returns 0 unconditionally and returning an error in a platform remove callback isn't very sensible. (The only effect of the latter is that the device core emits a generic warning and then removes the device anyhow.) So return 0 unconditionally to make it obvious there is no error forwarded to the upper layers. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20220610211257.102071-2-u.kleine-koenig@pengutronix.de Signed-off-by: Ulf Hansson --- diff --git a/drivers/mmc/host/dw_mmc-hi3798cv200.c b/drivers/mmc/host/dw_mmc-hi3798cv200.c index e9437ef8ef19d..6f22fe0540879 100644 --- a/drivers/mmc/host/dw_mmc-hi3798cv200.c +++ b/drivers/mmc/host/dw_mmc-hi3798cv200.c @@ -179,7 +179,9 @@ static int dw_mci_hi3798cv200_remove(struct platform_device *pdev) clk_disable_unprepare(priv->drive_clk); clk_disable_unprepare(priv->sample_clk); - return dw_mci_pltfm_remove(pdev); + dw_mci_pltfm_remove(pdev); + + return 0; } static const struct of_device_id dw_mci_hi3798cv200_match[] = {