From: Daniel Stenberg <daniel@haxx.se>
Date: Thu, 3 Jan 2019 11:59:28 +0000 (+0100)
Subject: ntlm: fix *_type3_message size check to avoid buffer overflow
X-Git-Tag: curl-7_64_0~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=50c9484278c63b958655a717844f0721263939cc;p=thirdparty%2Fcurl.git

ntlm: fix *_type3_message size check to avoid buffer overflow

Bug: https://curl.haxx.se/docs/CVE-2019-3822.html
Reported-by: Wenxiang Qian
CVE-2019-3822
---

diff --git a/lib/vauth/ntlm.c b/lib/vauth/ntlm.c
index 0ad4d972e3..6a8fc5ab3d 100644
--- a/lib/vauth/ntlm.c
+++ b/lib/vauth/ntlm.c
@@ -779,11 +779,14 @@ CURLcode Curl_auth_create_ntlm_type3_message(struct Curl_easy *data,
   });
 
 #ifdef USE_NTRESPONSES
-  if(size < (NTLM_BUFSIZE - ntresplen)) {
-    DEBUGASSERT(size == (size_t)ntrespoff);
-    memcpy(&ntlmbuf[size], ptr_ntresp, ntresplen);
-    size += ntresplen;
+  /* ntresplen + size should not be risking an integer overflow here */
+  if(ntresplen + size > sizeof(ntlmbuf)) {
+    failf(data, "incoming NTLM message too big");
+    return CURLE_OUT_OF_MEMORY;
   }
+  DEBUGASSERT(size == (size_t)ntrespoff);
+  memcpy(&ntlmbuf[size], ptr_ntresp, ntresplen);
+  size += ntresplen;
 
   DEBUG_OUT({
     fprintf(stderr, "\n   ntresp=");