From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 4 Jul 2019 18:12:13 +0000 (+0200)
Subject: loop-util: if we fail to fully set up a loop device, detach it again
X-Git-Tag: v245-rc1~310^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=50d046993be9d830570d2571b670ad49204db92a;p=thirdparty%2Fsystemd.git

loop-util: if we fail to fully set up a loop device, detach it again
---

diff --git a/src/shared/loop-util.c b/src/shared/loop-util.c
index c5574550664..bbb85f9e6e0 100644
--- a/src/shared/loop-util.c
+++ b/src/shared/loop-util.c
@@ -28,8 +28,8 @@ int loop_device_make_full(
         _cleanup_free_ char *loopdev = NULL;
         unsigned n_attempts = 0;
         struct loop_info64 info;
+        LoopDevice *d = NULL;
         struct stat st;
-        LoopDevice *d;
         int nr = -1, r;
 
         assert(fd >= 0);
@@ -114,12 +114,16 @@ int loop_device_make_full(
                 .lo_sizelimit = size == UINT64_MAX ? 0 : size,
         };
 
-        if (ioctl(loop, LOOP_SET_STATUS64, &info) < 0)
-                return -errno;
+        if (ioctl(loop, LOOP_SET_STATUS64, &info) < 0) {
+                r = -errno;
+                goto fail;
+        }
 
         d = new(LoopDevice, 1);
-        if (!d)
-                return -ENOMEM;
+        if (!d) {
+                r = -ENOMEM;
+                goto fail;
+        }
 
         *d = (LoopDevice) {
                 .fd = TAKE_FD(loop),
@@ -129,6 +133,14 @@ int loop_device_make_full(
 
         *ret = d;
         return d->fd;
+
+fail:
+        if (fd >= 0)
+                (void) ioctl(fd, LOOP_CLR_FD);
+        if (d && d->fd >= 0)
+                (void) ioctl(d->fd, LOOP_CLR_FD);
+
+        return r;
 }
 
 int loop_device_make_by_path(const char *path, int open_flags, uint32_t loop_flags, LoopDevice **ret) {