From: Shawn Routhier <sar@isc.org>
Date: Thu, 16 Apr 2015 19:11:02 +0000 (-0700)
Subject: [v4_1_esv] Leave siaddr clear when sending a NAK
X-Git-Tag: v4_1_esv_r12b1~14
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=50e99bef8e12e64bd7da36fac49d8bfe94f14ee2;p=thirdparty%2Fdhcp.git

[v4_1_esv] Leave siaddr clear when sending a NAK
---

diff --git a/RELNOTES b/RELNOTES
index c09004aac..ab5dda020 100644
--- a/RELNOTES
+++ b/RELNOTES
@@ -91,6 +91,10 @@ by Eric Young (eay@cryptsoft.com).
   or add a lease entry with a date far in the future.
   [ISC-Bugs #33056]
 
+- Leave the siaddr field clear when sending a NACK as per RFC 2131
+  table 3.
+  [ISC-Bugs #38769]
+
 			Changes since 4.1-ESV-R11rc2
 
 - None
diff --git a/server/dhcp.c b/server/dhcp.c
index cb414961a..d24f520e8 100644
--- a/server/dhcp.c
+++ b/server/dhcp.c
@@ -3,7 +3,7 @@
    DHCP Protocol engine. */
 
 /*
- * Copyright (c) 2004-2014 by Internet Systems Consortium, Inc. ("ISC")
+ * Copyright (c) 2004-2015 by Internet Systems Consortium, Inc. ("ISC")
  * Copyright (c) 1995-2003 by Internet Software Consortium
  *
  * Permission to use, copy, modify, and distribute this software for any
@@ -1432,8 +1432,6 @@ void nak_lease (packet, cip)
 	option_state_dereference (&options, MDL);
 
 /*	memset (&raw.ciaddr, 0, sizeof raw.ciaddr);*/
-	if (packet->interface->address_count)
-		raw.siaddr = packet->interface->addresses[0];
 	raw.giaddr = packet -> raw -> giaddr;
 	memcpy (raw.chaddr, packet -> raw -> chaddr, sizeof raw.chaddr);
 	raw.hlen = packet -> raw -> hlen;