From: Frédéric Buclin <LpSolit@gmail.com>
Date: Wed, 4 Aug 2010 21:33:33 +0000 (+0200)
Subject: Bug 417048: (CVE-2010-2756) [SECURITY] Boolean charts let me query for users being... 
X-Git-Tag: bugzilla-3.4.8~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=50fd93f3813f8d30ee05a45eb8e8e02c4770bc8b;p=thirdparty%2Fbugzilla.git

Bug 417048: (CVE-2010-2756) [SECURITY] Boolean charts let me query for users being in any given group
r=mkanat a=LpSolit
---

diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm
index e9abe72e73..51f611ac55 100644
--- a/Bugzilla/Search.pm
+++ b/Bugzilla/Search.pm
@@ -1220,7 +1220,8 @@ sub _contact_exact_group {
     $$v =~ m/%group\\.([^%]+)%/;
     my $group = $1;
     my $groupid = Bugzilla::Group::ValidateGroupName( $group, ($user));
-    $groupid || ThrowUserError('invalid_group_name',{name => $group});
+    ($groupid && $user->in_group_id($groupid))
+      || ThrowUserError('invalid_group_name',{name => $group});
     my @childgroups = @{Bugzilla::Group->flatten_group_membership($groupid)};
     my $table = "user_group_map_$$chartid";
     push (@$supptables, "LEFT JOIN user_group_map AS $table " .
@@ -1292,7 +1293,8 @@ sub _cc_exact_group {
     $$v =~ m/%group\\.([^%]+)%/;
     my $group = $1;
     my $groupid = Bugzilla::Group::ValidateGroupName( $group, ($user));
-    $groupid || ThrowUserError('invalid_group_name',{name => $group});
+    ($groupid && $user->in_group_id($groupid))
+      || ThrowUserError('invalid_group_name',{name => $group});
     my @childgroups = @{Bugzilla::Group->flatten_group_membership($groupid)};
     my $chartseq = $$chartid;
     if ($$chartid eq "") {