From: Tom Tromey Date: Mon, 26 Aug 2024 17:29:01 +0000 (-0600) Subject: Minor cleanup to ada_identical_enum_types_p X-Git-Tag: gdb-16-branchpoint~938 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=511c6575b2febee533a4d8796647bbabc2c27249;p=thirdparty%2Fbinutils-gdb.git Minor cleanup to ada_identical_enum_types_p This moves the declaration of 'i' into the 'for' loops in ada_identical_enum_types_p. This is just a trivial cleanup. Approved-By: Tom de Vries --- diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index 8d5d6671c8d..57f2b2bb9a7 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -4976,21 +4976,19 @@ is_nondebugging_type (struct type *type) static bool ada_identical_enum_types_p (struct type *type1, struct type *type2) { - int i; - /* The heuristic we use here is fairly conservative. We consider that 2 enumerate types are identical if they have the same number of enumerals and that all enumerals have the same underlying value and name. */ /* All enums in the type should have an identical underlying value. */ - for (i = 0; i < type1->num_fields (); i++) + for (int i = 0; i < type1->num_fields (); i++) if (type1->field (i).loc_enumval () != type2->field (i).loc_enumval ()) return false; /* All enumerals should also have the same name (modulo any numerical suffix). */ - for (i = 0; i < type1->num_fields (); i++) + for (int i = 0; i < type1->num_fields (); i++) { const char *name_1 = type1->field (i).name (); const char *name_2 = type2->field (i).name ();