From: Amos Jeffries <squid3@treenet.co.nz>
Date: Thu, 10 Nov 2011 01:35:23 +0000 (+1300)
Subject: Fix assertion when dstdomain abused in access controls
X-Git-Tag: BumpSslServerFirst.take01~32
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=51734f15a818d2eef8f0ca37df5c5f849dda086c;p=thirdparty%2Fsquid.git

Fix assertion when dstdomain abused in access controls

This converts an assertion into a logged warning and a failed-match if
dstdomain ACLs are used in places where the HTTP reuqest is not available.
---

diff --git a/src/acl/DestinationDomain.h b/src/acl/DestinationDomain.h
index 3245fdea56..e62d7234ff 100644
--- a/src/acl/DestinationDomain.h
+++ b/src/acl/DestinationDomain.h
@@ -47,6 +47,7 @@ class ACLDestinationDomainStrategy : public ACLStrategy<char const *>
 public:
     virtual int match (ACLData<MatchType> * &, ACLFilledChecklist *);
     static ACLDestinationDomainStrategy *Instance();
+    virtual bool requiresRequest() const {return true;}
 
     /**
      * Not implemented to prevent copies of the instance.