From: Helge Deller <deller@gmx.de>
Date: Sat, 27 May 2023 09:37:29 +0000 (+0200)
Subject: fbdev: imsttfb: Fix error path of imsttfb_probe()
X-Git-Tag: v6.4-rc5~25^2~7
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=518ecb6a209f6ff678aeadf9f2bf870c0982ca85;p=thirdparty%2Flinux.git

fbdev: imsttfb: Fix error path of imsttfb_probe()

Release ressources when init_imstt() returns failure.

Signed-off-by: Helge Deller <deller@gmx.de>
---

diff --git a/drivers/video/fbdev/imsttfb.c b/drivers/video/fbdev/imsttfb.c
index 075f119912815..ee7d01ad14068 100644
--- a/drivers/video/fbdev/imsttfb.c
+++ b/drivers/video/fbdev/imsttfb.c
@@ -1535,8 +1535,10 @@ static int imsttfb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 		goto error;
 	info->pseudo_palette = par->palette;
 	ret = init_imstt(info);
-	if (!ret)
-		pci_set_drvdata(pdev, info);
+	if (ret)
+		goto error;
+
+	pci_set_drvdata(pdev, info);
 	return ret;
 
 error: