From: Laine Stump Date: Fri, 4 Apr 2025 20:48:23 +0000 (-0400) Subject: qemu: remove nonsensical sanity check in processNetdevStreamDisconnectedEvent() X-Git-Tag: v11.3.0-rc1~33 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=51a54dc1c4ecf37d60acee1cb94252e51c5ef627;p=thirdparty%2Flibvirt.git qemu: remove nonsensical sanity check in processNetdevStreamDisconnectedEvent() By definition QEMU will never send a NETDEV_STREAM_DISCONNECTED event if it doesn't support the reconnect option for a stream netdev. And even if, by some comedy of errors, it did send NETDEV_STREAM_DISCONNECTED in that case, our response to the event doesn't request anything at all of QEMU (much less something that would fail if QEMU didn't understand NETDEV_STREAM_DISCONNECTED) - it just starts a new passt process to replace the one that has been terminated, so we don't need to check the QEMU capabilities for QEMU_CAPS_NETDEV_STREAM_RECONNECT. Signed-off-by: Laine Stump Tested-by: Stefano Brivio Reviewed-by: Jiri Denemark Reviewed-by: Michal Privoznik --- diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 3e48da080a..589778eaed 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3612,7 +3612,6 @@ processNetdevStreamDisconnectedEvent(virDomainObj *vm, { virDomainDeviceDef dev; virDomainNetDef *def; - virQEMUCaps *qemuCaps = QEMU_DOMAIN_PRIVATE(vm)->qemuCaps; const char *devAlias = STRSKIP(netdevId, "host"); /* The event sends us the "netdev-id", but we don't store the @@ -3658,12 +3657,6 @@ processNetdevStreamDisconnectedEvent(virDomainObj *vm, goto endjob; } - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_NETDEV_STREAM_RECONNECT)) { - VIR_WARN("ignore NETDEV_STREAM_DISCONNECTED event for passt network device %s in domain %s - QEMU binary does not support reconnect", - def->info.alias, vm->def->name); - goto endjob; - } - /* handle the event - restart the passt process with its original * parameters */