From: Hans Verkuil Date: Fri, 6 Oct 2023 10:08:47 +0000 (+0200) Subject: media: qcom: venus: fix incorrect return value X-Git-Tag: v6.7-rc1~51^2~27 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=51b74c09ac8c5862007fc2bf0d465529d06dd446;p=thirdparty%2Fkernel%2Flinux.git media: qcom: venus: fix incorrect return value 'pd' can be NULL, and in that case it shouldn't be passed to PTR_ERR. Fixes a smatch warning: drivers/media/platform/qcom/venus/pm_helpers.c:873 vcodec_domains_get() warn: passing zero to 'PTR_ERR' Signed-off-by: Hans Verkuil Reviewed-by: Bryan O'Donoghue --- diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c index 48c9084bb4dba..a1b127caa90a7 100644 --- a/drivers/media/platform/qcom/venus/pm_helpers.c +++ b/drivers/media/platform/qcom/venus/pm_helpers.c @@ -870,7 +870,7 @@ static int vcodec_domains_get(struct venus_core *core) pd = dev_pm_domain_attach_by_name(dev, res->vcodec_pmdomains[i]); if (IS_ERR_OR_NULL(pd)) - return PTR_ERR(pd) ? : -ENODATA; + return pd ? PTR_ERR(pd) : -ENODATA; core->pmdomains[i] = pd; }