From: Aki Tuomi <cmouse@cmouse.fi>
Date: Wed, 26 Apr 2017 06:55:13 +0000 (+0300)
Subject: geoipbackend: Use dns_random
X-Git-Tag: rec-4.1.0-alpha1~141^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=51c38f5bba8bafcd10d8709dcf60ec0a3f697abe;p=thirdparty%2Fpdns.git

geoipbackend: Use dns_random

Closes coverity CID#1374548
---

diff --git a/modules/geoipbackend/geoipbackend.cc b/modules/geoipbackend/geoipbackend.cc
index f70e126091..b10a54b639 100644
--- a/modules/geoipbackend/geoipbackend.cc
+++ b/modules/geoipbackend/geoipbackend.cc
@@ -23,6 +23,7 @@
 #include "config.h"
 #endif
 #include "geoipbackend.hh"
+#include "pdns/dns_random.hh"
 #include <sstream>
 #include <regex.h>
 #include <glob.h>
@@ -305,7 +306,7 @@ GeoIPBackend::~GeoIPBackend() {
 bool GeoIPBackend::lookup_static(const GeoIPDomain &dom, const DNSName &search, const QType &qtype, const DNSName& qdomain, const std::string &ip, GeoIPLookup &gl, bool v6) {
   const auto i = dom.records.find(search);
   int cumul_probability = 0;
-  int probability_rnd = 1+(random() % 1000); // setting probability=0 means it never is used
+  int probability_rnd = 1+(dns_random(1000)); // setting probability=0 means it never is used
 
   if (i != dom.records.end()) { // return static value
     for(const auto& rr : i->second) {