From: Bruce Momjian <bruce@momjian.us>
Date: Sat, 5 Feb 2011 04:27:45 +0000 (-0500)
Subject: Add C comment about why older compilers complain about basebackup.c's
X-Git-Tag: REL9_1_ALPHA4~262
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=51dbc87dff5c32bfe627ec7b22c575c263de8251;p=thirdparty%2Fpostgresql.git

Add C comment about why older compilers complain about basebackup.c's
longjump.
---

diff --git a/src/backend/replication/basebackup.c b/src/backend/replication/basebackup.c
index b5cda5063be..d94b61f23ef 100644
--- a/src/backend/replication/basebackup.c
+++ b/src/backend/replication/basebackup.c
@@ -217,6 +217,12 @@ perform_base_backup(basebackup_options *opt, DIR *tblspcdir)
 				ptr.xlogid = logid;
 				ptr.xrecoff = logseg * XLogSegSize + TAR_SEND_SIZE * i;
 
+				/*
+				 *	Some old compilers, e.g. 2.95.3/x86, think that passing
+				 *	a struct in the same function as a longjump might clobber
+				 *	a variable.  bjm 2011-02-04
+				 *	http://lists.apple.com/archives/xcode-users/2003/Dec//msg00051.html
+				 */
 				XLogRead(buf, ptr, TAR_SEND_SIZE);
 				if (pq_putmessage('d', buf, TAR_SEND_SIZE))
 					ereport(ERROR,