From: Jonathan Wakely <jwakely@redhat.com>
Date: Wed, 23 Nov 2022 10:01:06 +0000 (+0000)
Subject: doc: -Wdelete-non-virtual-dtor supersedes -Wnon-virtual-dtor
X-Git-Tag: basepoints/gcc-14~2941
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=51f28e3aaf8b50554e7d356c8117399e63132323;p=thirdparty%2Fgcc.git

doc: -Wdelete-non-virtual-dtor supersedes -Wnon-virtual-dtor

The newer -Wdelete-non-virtual-dtor has no false positives and fewer
bugs. There is very little reason to use -Wnon-virtual-dtor instead.

gcc/ChangeLog:

	* doc/invoke.texi (C++ Dialect Options): Recommend using
	-Wdelete-non-virtual-dtor instead of -Wnon-virtual-dtor.
---

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 330da6eb5d40..4899bd1ea4c0 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -3986,6 +3986,9 @@ destructor itself or in an accessible polymorphic base class, in which
 case it is possible but unsafe to delete an instance of a derived
 class through a pointer to the class itself or base class.  This
 warning is automatically enabled if @option{-Weffc++} is specified.
+The @option{-Wdelete-non-virtual-dtor} option (enabled by @option{-Wall})
+should be preferred because it warns about the unsafe cases without false
+positives.
 
 @item -Wregister @r{(C++ and Objective-C++ only)}
 @opindex Wregister