From: Vsevolod Stakhov <vsevolod@highsecure.ru>
Date: Fri, 17 Sep 2021 20:47:17 +0000 (+0100)
Subject: [Minor] Fix some double frees
X-Git-Tag: 3.1~151
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=52041f014b47aa9f67bbaecda08a0fb18673cb93;p=thirdparty%2Frspamd.git

[Minor] Fix some double frees

Found by: coverity scan
---

diff --git a/src/libmime/archives.c b/src/libmime/archives.c
index 4d7867f678..1101213d19 100644
--- a/src/libmime/archives.c
+++ b/src/libmime/archives.c
@@ -254,6 +254,8 @@ rspamd_archive_process_zip (struct rspamd_task *task,
 		}
 		else {
 			g_free (f);
+
+			return;
 		}
 
 		/* Process extra fields */
diff --git a/src/libserver/dns.c b/src/libserver/dns.c
index c23390a47f..0eff240a66 100644
--- a/src/libserver/dns.c
+++ b/src/libserver/dns.c
@@ -652,6 +652,7 @@ rspamd_process_fake_reply (struct rspamd_config *cfg,
 					else {
 						DL_APPEND (replies, rep);
 					}
+					break;
 				case RDNS_REQUEST_SRV:
 				default:
 					msg_err_config ("invalid or unsupported reply element "
diff --git a/src/libutil/rrd.c b/src/libutil/rrd.c
index a270d87c64..09e488f9ad 100644
--- a/src/libutil/rrd.c
+++ b/src/libutil/rrd.c
@@ -747,7 +747,7 @@ rspamd_rrd_finalize (struct rspamd_rrd_file *file, GError **err)
 		close (fd);
 		g_set_error (err,
 			rrd_error_quark (), ENOMEM, "mmap failed: %s", strerror (errno));
-		g_free (file);
+
 		return FALSE;
 	}