From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Tue, 17 Jan 2017 13:22:44 +0000 (+0200)
Subject: doveadm direcor add: Don't accept number as a valid hostname.
X-Git-Tag: 2.3.0.rc1~2295
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=521c0460fe705f32ea6899c8b1f101043fe0898c;p=thirdparty%2Fdovecot%2Fcore.git

doveadm direcor add: Don't accept number as a valid hostname.

This is usually a mistake. For example "doveadm director add -t host 100"
shouldn't be adding a new IP 100 (0.0.0.100)
---

diff --git a/src/doveadm/doveadm-director.c b/src/doveadm/doveadm-director.c
index fb7d96fbc4..42c472759d 100644
--- a/src/doveadm/doveadm-director.c
+++ b/src/doveadm/doveadm-director.c
@@ -469,6 +469,13 @@ cmd_director_add_or_update(struct doveadm_cmd_context *cctx, bool update)
 		director_cmd_help(cctx->cmd);
 		return;
 	}
+	if (str_to_uint(host, &i) == 0) {
+		/* host is a number. this would translate to an IP address,
+		   which is probably a mistake. */
+		i_error("Invalid host '%s'", host);
+		director_cmd_help(cctx->cmd);
+		return;
+	}
 
 	host = ctx->host;
 	if (ctx->tag == NULL) {