From: Johannes Thumshirn Date: Wed, 31 May 2023 11:50:35 +0000 (-0700) Subject: floppy: use __bio_add_page for adding single page to bio X-Git-Tag: v6.5-rc1~114^2~155 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5225229b8fdfb3e65520c43547ecf9a737161c3f;p=thirdparty%2Flinux.git floppy: use __bio_add_page for adding single page to bio The floppy code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Reviewed-by: Christoph Hellwig Reviewed-by: Damien Le Moal Signed-off-by: Johannes Thumshirn Link: https://lore.kernel.org/r/33c445a3b431270c72d9be03d5da1b08ae983920.1685532726.git.johannes.thumshirn@wdc.com Signed-off-by: Jens Axboe --- diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index cec2c20f5e59d..28ec6b442e9c5 100644 --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c @@ -4147,7 +4147,7 @@ static int __floppy_read_block_0(struct block_device *bdev, int drive) cbdata.drive = drive; bio_init(&bio, bdev, &bio_vec, 1, REQ_OP_READ); - bio_add_page(&bio, page, block_size(bdev), 0); + __bio_add_page(&bio, page, block_size(bdev), 0); bio.bi_iter.bi_sector = 0; bio.bi_flags |= (1 << BIO_QUIET);