From: Ramkumar Ramachandra Date: Sun, 2 Jun 2013 14:03:42 +0000 (+0530) Subject: completion: show can take both revlist and paths X-Git-Tag: v1.8.4-rc0~167^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5269f7f8c6b293f1568c4f03c14596835e22df31;p=thirdparty%2Fgit.git completion: show can take both revlist and paths The 'git show' completion uses __git_complete_file (aliased to __git_complete_revlist_file), because accepts : as well as . But the command also accepts range of commits in A..B notation, so using __git_complete_revlist_file is more appropriate. There still remain two users of __git_complete_file, completions for "archive" and "ls-tree". As these commands do not take range notation, and "git show" no longer uses __git_complete_file, the implementation of it can be updated not to complete ranges, but that is a separate topic. Signed-off-by: Ramkumar Ramachandra Signed-off-by: Junio C Hamano --- diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 1b4b0f95a9..b9dfc3be75 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -2360,7 +2360,7 @@ _git_show () return ;; esac - __git_complete_file + __git_complete_revlist_file } _git_show_branch ()