From: Jesper Dangaard Brouer <hawk@comx.dk>
Date: Thu, 3 Jul 2008 18:29:34 +0000 (+0200)
Subject: libiptc: minor bugfix
X-Git-Tag: v1.4.2-rc1~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=526d3e138635e33773d1ca16477052a04f53f5bd;p=thirdparty%2Fiptables.git

libiptc: minor bugfix

Minor bugfix, an extra check is needed if the tail element is a
builtin chain, as builtin chains are not sorted.

Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
Signed-off-by: Patrick McHardy <kaber@trash.net>
---

diff --git a/libiptc/libiptc.c b/libiptc/libiptc.c
index d0f51b4a..ec5317bc 100644
--- a/libiptc/libiptc.c
+++ b/libiptc/libiptc.c
@@ -819,7 +819,8 @@ static void __iptcc_p_add_chain(TC_HANDLE_T h, struct chain_head *c,
 		list_add_tail(&c->list, &h->chains);
 	else {
 		ctail = list_entry(tail, struct chain_head, list);
-		if (strcmp(c->name, ctail->name) > 0)
+		if (strcmp(c->name, ctail->name) > 0 ||
+		    iptcc_is_builtin(ctail))
 			list_add_tail(&c->list, &h->chains);/* Already sorted*/
 		else
 			iptc_insert_chain(h, c);/* Was not sorted */