From: Pavel Hrdina <phrdina@redhat.com>
Date: Mon, 24 Mar 2025 19:11:58 +0000 (+0100)
Subject: qemu_driver: Fix virDomainSaveImageDefineXML
X-Git-Tag: v11.2.0-rc2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=52e3f3041f98f93f58aa5a902ddab3d4ed6cb4d2;p=thirdparty%2Flibvirt.git

qemu_driver: Fix virDomainSaveImageDefineXML

Commit 28a06215280b99708ed8dc2d183f62ba7b34ccf8 added support to restore
sparse images but changed the boolean that controls if we open the file
as read-only or read-write. Editing XML in the save image resulted in
following error message:

    failed to write header to domain save file '/data/images/fedora40.save': Bad file descriptor

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Jim Fehlig <jfehlig@suse.com>
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 1be32c01b1..6ce949dd07 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5948,7 +5948,7 @@ qemuDomainSaveImageDefineXML(virConnectPtr conn, const char *path,
     if (qemuSaveImageGetMetadata(driver, NULL, path, &def, &data) < 0)
         goto cleanup;
 
-    fd = qemuSaveImageOpen(driver, path, false, false, NULL, false);
+    fd = qemuSaveImageOpen(driver, path, false, false, NULL, true);
 
     if (fd < 0)
         goto cleanup;