From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Mon, 2 Jan 2023 14:49:38 +0000 (+0100)
Subject: Do *not* use QName Minimization for DS retrievals in QM fallback mode.
X-Git-Tag: dnsdist-1.8.0-rc1~97^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=52f994cd675e10e2373b56ffc3107478bf3ed2e7;p=thirdparty%2Fpdns.git

Do *not* use QName Minimization for DS retrievals in QM fallback mode.
---

diff --git a/pdns/recursordist/syncres.cc b/pdns/recursordist/syncres.cc
index 2b46e54af0..103d428077 100644
--- a/pdns/recursordist/syncres.cc
+++ b/pdns/recursordist/syncres.cc
@@ -1773,6 +1773,8 @@ int SyncRes::doResolve(const DNSName& qname, const QType qtype, vector<DNSRecord
         // Case 5: unexpected answer
         QLOG("Step5: other rcode, last effort final resolve");
         setQNameMinimization(false);
+        setQMFallbackMode(true);
+
         // We might have hit a depth level check, but we still want to allow some recursion levels in the fallback
         // no-qname-minimization case. This has the effect that a qname minimization fallback case might reach 150% of
         // maxdepth.
@@ -3600,7 +3602,7 @@ vState SyncRes::getDSRecords(const DNSName& zone, dsmap_t& ds, bool taOnly, unsi
   Context context;
 
   const bool oldCacheOnly = setCacheOnly(false);
-  const bool oldQM = setQNameMinimization(true);
+  const bool oldQM = setQNameMinimization(!getQMFallbackMode());
   int rcode = doResolve(zone, QType::DS, dsrecords, depth + 1, beenthere, context);
   setCacheOnly(oldCacheOnly);
   setQNameMinimization(oldQM);
diff --git a/pdns/recursordist/syncres.hh b/pdns/recursordist/syncres.hh
index 1fa9ff63e0..24cda26084 100644
--- a/pdns/recursordist/syncres.hh
+++ b/pdns/recursordist/syncres.hh
@@ -348,6 +348,18 @@ public:
     return old;
   }
 
+  bool setQMFallbackMode(bool state = true)
+  {
+    auto old = d_qNameMinimizationFalbackMode;
+    d_qNameMinimizationFalbackMode = state;
+    return old;
+  }
+
+  bool getQMFallbackMode() const
+  {
+    return d_qNameMinimizationFalbackMode;
+  }
+  
   void setDoEDNS0(bool state = true)
   {
     d_doEDNS0 = state;
@@ -678,6 +690,7 @@ private:
   bool d_wasOutOfBand{false};
   bool d_wasVariable{false};
   bool d_qNameMinimization{false};
+  bool d_qNameMinimizationFalbackMode{false};
   bool d_queryReceivedOverTCP{false};
   bool d_followCNAME{true};
   bool d_refresh{false};