From: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: Tue, 1 Apr 2025 14:43:32 +0000 (+0200)
Subject: tcg: Allocate TEMP_VAL_MEM frame in temp_load()
X-Git-Tag: v9.2.4~51
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5313973fd495d788bd2b42f0b6a4af0213f3b245;p=thirdparty%2Fqemu.git

tcg: Allocate TEMP_VAL_MEM frame in temp_load()

Be sure to allocate the temp frame if it wasn't.

In the resolved issues, incomplete dead code elimination left a load
at the top of an unreachable loop.  We simply need to allocate the
stack slot to avoid crashing.

Fixes: c896fe29d6c ("TCG code generator")
Reported-by: Michael Tokarev <mjt@tls.msk.ru>
Reported-by: Helge Konetzka <hk@zapateado.de>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2891
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2899
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-ID: <20250401144332.41615-1-philmd@linaro.org>
(cherry picked from commit e139bc4b1772575e1f2dcf8e3dbe1df2b684ef1f)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---

diff --git a/tcg/tcg.c b/tcg/tcg.c
index 4578b185be..13f735b246 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -4461,6 +4461,9 @@ static void temp_load(TCGContext *s, TCGTemp *ts, TCGRegSet desired_regs,
         ts->mem_coherent = 0;
         break;
     case TEMP_VAL_MEM:
+        if (!ts->mem_allocated) {
+            temp_allocate_frame(s, ts);
+        }
         reg = tcg_reg_alloc(s, desired_regs, allocated_regs,
                             preferred_regs, ts->indirect_base);
         tcg_out_ld(s, ts->type, reg, ts->mem_base->reg, ts->mem_offset);