From: Vladimir Sementsov-Ogievskiy Date: Fri, 22 Sep 2017 14:43:53 +0000 (+0300) Subject: block/qcow2-bitmap: fix use of uninitialized pointer X-Git-Tag: v2.11.0-rc0~76^2^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5330f32b71b1868bdb3b444733063cb5adc4e8e6;p=thirdparty%2Fqemu.git block/qcow2-bitmap: fix use of uninitialized pointer Without initialization to zero dirty_bitmap field may be not zero for a bitmap which should not be stored and qcow2_store_persistent_dirty_bitmaps will erroneously call store_bitmap for it which leads to SIGSEGV on bdrv_dirty_bitmap_name. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-id: 20170922144353.4220-1-vsementsov@virtuozzo.com Cc: qemu-stable@nongnu.org Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Max Reitz --- diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c index e8d3bdbd6ea..14f41d04270 100644 --- a/block/qcow2-bitmap.c +++ b/block/qcow2-bitmap.c @@ -602,7 +602,7 @@ static Qcow2BitmapList *bitmap_list_load(BlockDriverState *bs, uint64_t offset, goto fail; } - bm = g_new(Qcow2Bitmap, 1); + bm = g_new0(Qcow2Bitmap, 1); bm->table.offset = e->bitmap_table_offset; bm->table.size = e->bitmap_table_size; bm->flags = e->flags;