From: Glen Choo <chooglen@google.com>
Date: Tue, 29 Mar 2022 20:01:19 +0000 (+0000)
Subject: branch: remove negative exit code
X-Git-Tag: v2.36.0-rc0~9^2~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5391e94813418dfb5ccc4c2f1d8518995b4f3ca5;p=thirdparty%2Fgit.git

branch: remove negative exit code

Replace an instance of "exit(-1)" with "exit(1)". We don't use negative
exit codes - they are misleading because Unix machines will coerce them
to 8-bit unsigned values, losing the sign.

Signed-off-by: Glen Choo <chooglen@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/branch.c b/branch.c
index add6a37b79..ed6f993aa6 100644
--- a/branch.c
+++ b/branch.c
@@ -263,7 +263,7 @@ static void setup_tracking(const char *new_ref, const char *orig_ref,
 		string_list_append(tracking.srcs, orig_ref);
 	if (install_branch_config_multiple_remotes(config_flags, new_ref,
 				tracking.remote, tracking.srcs) < 0)
-		exit(-1);
+		exit(1);
 
 cleanup:
 	string_list_clear(&tracking_srcs, 0);