From: Christopher Faulet Date: Tue, 21 Jan 2020 09:13:03 +0000 (+0100) Subject: CLEANUP: http-ana: Remove useless test on txn when the error message is retrieved X-Git-Tag: v2.2-dev1~10 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=53a87e134e898937d6e59177c5731533fbba0558;p=thirdparty%2Fhaproxy.git CLEANUP: http-ana: Remove useless test on txn when the error message is retrieved In http_error_message(), the HTTP txn is always defined. So, this is no reason to test its nullity. This patch partially fixes the issue #457. --- diff --git a/src/http_ana.c b/src/http_ana.c index 82a9e14a26..23db04ece5 100644 --- a/src/http_ana.c +++ b/src/http_ana.c @@ -4603,7 +4603,7 @@ struct buffer *http_error_message(struct stream *s) { const int msgnum = http_get_status_idx(s->txn->status); - if (s->txn && s->txn->errmsg) + if (s->txn->errmsg) return s->txn->errmsg; else if (s->be->errmsg[msgnum]) return s->be->errmsg[msgnum];