From: Atul Gupta <atul.gupta@chelsio.com>
Date: Sun, 27 May 2018 15:45:20 +0000 (+0530)
Subject: crypto: chtls: dereference null variable
X-Git-Tag: v4.18-rc1~114^2~105
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=53bcfb68c47dc0f2f1f6a2331dffdc9fbb98b116;p=thirdparty%2Fkernel%2Flinux.git

crypto: chtls: dereference null variable

skb dereferenced before check in sendpage

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Atul Gupta <atul.gupta@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/crypto/chelsio/chtls/chtls_io.c b/drivers/crypto/chelsio/chtls/chtls_io.c
index b6f2607f624e8..45107726308f4 100644
--- a/drivers/crypto/chelsio/chtls/chtls_io.c
+++ b/drivers/crypto/chelsio/chtls/chtls_io.c
@@ -1230,9 +1230,8 @@ int chtls_sendpage(struct sock *sk, struct page *page,
 		struct sk_buff *skb = skb_peek_tail(&csk->txq);
 		int copy, i;
 
-		copy = mss - skb->len;
 		if (!skb || (ULP_SKB_CB(skb)->flags & ULPCB_FLAG_NO_APPEND) ||
-		    copy <= 0) {
+		    (copy = mss - skb->len) <= 0) {
 new_buf:
 			if (!csk_mem_free(cdev, sk))
 				goto wait_for_sndbuf;