From: Volker Rümelin <vr_qemu@t-online.de>
Date: Sun, 13 Dec 2020 13:05:26 +0000 (+0100)
Subject: coreaudio: don't start playback in init routine
X-Git-Tag: v6.0.0-rc0~179^2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=53e78d1cfb43df733a278172dd11bc40d2fe69c8;p=thirdparty%2Fqemu.git

coreaudio: don't start playback in init routine

Every emulated audio device has a way to enable audio playback. Don't
start playback until the guest enables the audio device to keep the
Core Audio device run state in sync with hw->enabled.

Tested-by: Howard Spoelstra <hsp.cat7@gmail.com>
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 20201213130528.5863-2-vr_qemu@t-online.de
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---

diff --git a/audio/coreaudio.c b/audio/coreaudio.c
index 0ee85052c45..a5df9505146 100644
--- a/audio/coreaudio.c
+++ b/audio/coreaudio.c
@@ -584,17 +584,6 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as,
         return -1;
     }
 
-    /* start Playback */
-    if (!isPlaying(core->outputDeviceID)) {
-        status = AudioDeviceStart(core->outputDeviceID, core->ioprocid);
-        if (status != kAudioHardwareNoError) {
-            coreaudio_logerr2 (status, typ, "Could not start playback\n");
-            AudioDeviceDestroyIOProcID(core->outputDeviceID, core->ioprocid);
-            core->outputDeviceID = kAudioDeviceUnknown;
-            return -1;
-        }
-    }
-
     return 0;
 }