From: Dan Carpenter Date: Wed, 20 Jan 2021 09:59:13 +0000 (+0300) Subject: ASoC: topology: Fix memory corruption in soc_tplg_denum_create_values() X-Git-Tag: v5.11-rc6~34^2~1^2~11 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=543466ef3571069b8eb13a8ff7c7cfc8d8a75c43;p=thirdparty%2Fkernel%2Flinux.git ASoC: topology: Fix memory corruption in soc_tplg_denum_create_values() The allocation uses sizeof(u32) when it should use sizeof(unsigned long) so it leads to memory corruption later in the function when the data is initialized. Fixes: 5aebe7c7f9c2 ("ASoC: topology: fix endianness issues") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/YAf+8QZoOv+ct526@mwanda Signed-off-by: Mark Brown --- diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c index 950c45008e245..37a5d73e643b8 100644 --- a/sound/soc/soc-topology.c +++ b/sound/soc/soc-topology.c @@ -902,7 +902,7 @@ static int soc_tplg_denum_create_values(struct soc_tplg *tplg, struct soc_enum * return -EINVAL; se->dobj.control.dvalues = devm_kcalloc(tplg->dev, le32_to_cpu(ec->items), - sizeof(u32), + sizeof(*se->dobj.control.dvalues), GFP_KERNEL); if (!se->dobj.control.dvalues) return -ENOMEM;