From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Tue, 15 Aug 2017 13:50:16 +0000 (+0300)
Subject: dict-sql: Cleanup - Remove unnecessary code
X-Git-Tag: 2.3.0.rc1~1061
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5451d6b31e9bf9d673bb014804c0cd5f1bfeb4db;p=thirdparty%2Fdovecot%2Fcore.git

dict-sql: Cleanup - Remove unnecessary code

The values are explicitly added to params. sql_dict_update_query() doesn't
add them again. Since the "diff" parameter is already a long long type,
this avoids unnecessary conversion to string and back.
---

diff --git a/src/lib-dict/dict-sql.c b/src/lib-dict/dict-sql.c
index d9677cc938..af69e870cd 100644
--- a/src/lib-dict/dict-sql.c
+++ b/src/lib-dict/dict-sql.c
@@ -1240,7 +1240,7 @@ static void sql_dict_atomic_inc_real(struct sql_dict_transaction_context *ctx,
 	i_assert(map != NULL);
 
 	field.map = map;
-	field.value = t_strdup_printf("%lld", diff);
+	field.value = NULL; /* unused */
 
 	i_zero(&build);
 	build.dict = dict;
@@ -1429,10 +1429,9 @@ static void sql_dict_atomic_inc(struct dict_transaction_context *_ctx,
 
 		field = array_append_space(&build.fields);
 		field->map = ctx->prev_inc_map;
-		field->value = t_strdup_printf("%lld", ctx->prev_inc_diff);
 		field = array_append_space(&build.fields);
 		field->map = map;
-		field->value = t_strdup_printf("%lld", diff);
+		/* field->value is unused */
 
 		t_array_init(&params, 4);
 		param = array_append_space(&params);