From: Tim Peters <tim.peters@gmail.com>
Date: Sat, 27 Jan 2001 06:20:08 +0000 (+0000)
Subject: SF bug http://sourceforge.net/bugs/?func=detailbug&bug_id=130242&group_id=5470
X-Git-Tag: v2.1a2~141
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=547397c45b4c6334ac6e8ee713de012a05a4fe4a;p=thirdparty%2FPython%2Fcpython.git

SF bug http://sourceforge.net/bugs/?func=detailbug&bug_id=130242&group_id=5470
SF patch http://sourceforge.net/patch/?func=detailpatch&patch_id=103453&group_id=5470
PyMember_Set of T_CHAR always raises exception.
Unfortunately, this is a use of a C API function that Python itself never makes, so
there's no .py test I can check in to verify this stays fixed.  But the fault in the
code is obvious, and Dave Cole's patch just as obviously fixes it.
---

diff --git a/Misc/ACKS b/Misc/ACKS
index 95685475af52..554203fefc87 100644
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -72,6 +72,7 @@ Tom Christiansen
 Vadim Chugunov
 Mike Clarkson
 Steve Clift
+Dave Cole
 Jeffery Collins
 Matt Conway
 Scott Cotton
diff --git a/Python/structmember.c b/Python/structmember.c
index bc1ba251acce..e155a6b49f8c 100644
--- a/Python/structmember.c
+++ b/Python/structmember.c
@@ -231,6 +231,7 @@ PyMember_Set(char *addr, struct memberlist *mlist, char *name, PyObject *v)
 					PyErr_BadArgument();
 					return -1;
 				}
+				break;
 			default:
 				PyErr_SetString(PyExc_SystemError,
 						"bad memberlist type");