From: Sanchayan Maity <maitysanchayan@gmail.com>
Date: Mon, 8 Aug 2016 11:26:17 +0000 (+0530)
Subject: cmd: dfu: Add error handling for failed registration
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=54a708ca06830c3fe3df8c0001ab33df784701f9;p=people%2Fms%2Fu-boot.git

cmd: dfu: Add error handling for failed registration

Without this, if g_dnl_register() fails, DFU code continues on
blindly and crashes. This fix makes it simply print an error
message instead.

Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
[l.majewski@samsung.com - some manual tweaks needed]
---

diff --git a/common/dfu.c b/common/dfu.c
index 14b60f1fbb..4c529f7c36 100644
--- a/common/dfu.c
+++ b/common/dfu.c
@@ -26,7 +26,12 @@ int run_usb_dnl_gadget(int usbctrl_index, char *usb_dnl_gadget)
 
 	board_usb_init(usbctrl_index, USB_INIT_DEVICE);
 	g_dnl_clear_detach();
-	g_dnl_register(usb_dnl_gadget);
+	ret = g_dnl_register(usb_dnl_gadget);
+	if (ret) {
+		error("g_dnl_register failed");
+		return CMD_RET_FAILURE;
+	}
+
 	while (1) {
 		if (g_dnl_detach()) {
 			/*