From: Alex Henrie Date: Tue, 1 Oct 2019 02:29:36 +0000 (-0600) Subject: wrapper: use a loop instead of repetitive statements X-Git-Tag: v2.24.0-rc0~47^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=54a80a9ad84af001470ea22fb0a14f6dc844b9c9;p=thirdparty%2Fgit.git wrapper: use a loop instead of repetitive statements A check into the history of this code revealed no particular reason for the code to be written in this way. All popular compilers are capable of unrolling loops if it benefits performance, and once this code is replaced with a loop, the magic number 6 used in multiple places in this function can be replaced with a named constant. Reviewed-by: Derrick Stolee Reviewed-by: Johannes Schindelin Reviewed-by: Jeff King Signed-off-by: Alex Henrie Signed-off-by: Junio C Hamano --- diff --git a/wrapper.c b/wrapper.c index 1e45ab7b92..54541386c1 100644 --- a/wrapper.c +++ b/wrapper.c @@ -506,13 +506,12 @@ int git_mkstemps_mode(char *pattern, int suffix_len, int mode) filename_template = &pattern[len - 6 - suffix_len]; for (count = 0; count < TMP_MAX; ++count) { uint64_t v = value; + int i; /* Fill in the random bits. */ - filename_template[0] = letters[v % num_letters]; v /= num_letters; - filename_template[1] = letters[v % num_letters]; v /= num_letters; - filename_template[2] = letters[v % num_letters]; v /= num_letters; - filename_template[3] = letters[v % num_letters]; v /= num_letters; - filename_template[4] = letters[v % num_letters]; v /= num_letters; - filename_template[5] = letters[v % num_letters]; v /= num_letters; + for (i = 0; i < 6; i++) { + filename_template[i] = letters[v % num_letters]; + v /= num_letters; + } fd = open(pattern, O_CREAT | O_EXCL | O_RDWR, mode); if (fd >= 0)