From: Aki Tuomi <aki.tuomi@dovecot.fi>
Date: Fri, 14 Oct 2016 12:28:32 +0000 (+0300)
Subject: lib-dcrypt: Fix uninitialized memory
X-Git-Tag: 2.2.26~128
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=54b9c839868b4d83bf5ce4798eed8a3363ff30c8;p=thirdparty%2Fdovecot%2Fcore.git

lib-dcrypt: Fix uninitialized memory
---

diff --git a/src/lib-dcrypt/dcrypt-openssl.c b/src/lib-dcrypt/dcrypt-openssl.c
index 8438a45af3..2011ec4a5d 100644
--- a/src/lib-dcrypt/dcrypt-openssl.c
+++ b/src/lib-dcrypt/dcrypt-openssl.c
@@ -729,6 +729,7 @@ static
 bool dcrypt_openssl_generate_keypair(struct dcrypt_keypair *pair_r, enum dcrypt_key_type kind, unsigned int bits, const char *curve, const char **error_r)
 {
 	EVP_PKEY *pkey = NULL;
+	memset(pair_r, 0, sizeof(struct dcrypt_keypair));
 	if (kind == DCRYPT_KEY_RSA) {
 		if (dcrypt_openssl_generate_rsa_key(bits, &pkey, error_r)) {
 			pair_r->priv = i_new(struct dcrypt_private_key, 1);
diff --git a/src/lib-dcrypt/test-crypto.c b/src/lib-dcrypt/test-crypto.c
index d511d308f6..a139dd6db0 100644
--- a/src/lib-dcrypt/test-crypto.c
+++ b/src/lib-dcrypt/test-crypto.c
@@ -636,6 +636,7 @@ void test_get_info_pw_encrypted(void) {
 	test_begin("test_get_info_pw_encrypted");
 
 	struct dcrypt_keypair p1;
+	memset(&p1, 0, sizeof(p1));
 	const char *error;
 	bool ret = dcrypt_keypair_generate(&p1, DCRYPT_KEY_EC, 0, "sect571k1", &error);
 	test_assert(ret == TRUE);