From: two-heart <12869538+two-heart@users.noreply.github.com>
Date: Thu, 4 Sep 2025 09:18:01 +0000 (+0200)
Subject: Add missing unlock to ossl_provider_new
X-Git-Tag: openssl-3.6.0-beta1~32
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=55209aab56da20f59f6c1b473f647990b1aa671d;p=thirdparty%2Fopenssl.git

Add missing unlock to ossl_provider_new

unlock on the early return path

CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28437)

(cherry picked from commit c89b46826caff4ced320268f284d963ff06dee77)
---

diff --git a/crypto/provider_core.c b/crypto/provider_core.c
index e1c8aa7c8d3..74b7d3d8ac1 100644
--- a/crypto/provider_core.c
+++ b/crypto/provider_core.c
@@ -562,8 +562,10 @@ OSSL_PROVIDER *ossl_provider_new(OSSL_LIB_CTX *libctx, const char *name,
             template.parameters = sk_INFOPAIR_deep_copy(p->parameters,
                                                         infopair_copy,
                                                         infopair_free);
-            if (template.parameters == NULL)
+            if (template.parameters == NULL) {
+                CRYPTO_THREAD_unlock(store->lock);
                 return NULL;
+            }
             break;
         }
         CRYPTO_THREAD_unlock(store->lock);