From: Ralph Boehme <slow@samba.org>
Date: Thu, 2 Apr 2020 07:13:56 +0000 (+0200)
Subject: smbd: reformat an if expression in reply_readbraw()
X-Git-Tag: ldb-2.2.0~1003
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=553e576ad9715bec1f96f44598fc6a0813c6989d;p=thirdparty%2Fsamba.git

smbd: reformat an if expression in reply_readbraw()

No change in behaviour.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c
index b23a2d373b2..62465a17fcf 100644
--- a/source3/smbd/reply.c
+++ b/source3/smbd/reply.c
@@ -3999,9 +3999,13 @@ void reply_readbraw(struct smb_request *req)
 	 * not a NTSTATUS.
 	 */
 
-	if (!fsp || !conn || conn != fsp->conn ||
-			req->vuid != fsp->vuid ||
-			fsp->is_directory || fsp->fh->fd == -1) {
+	if (fsp == NULL ||
+	    conn == NULL ||
+	    conn != fsp->conn ||
+	    req->vuid != fsp->vuid ||
+	    fsp->is_directory ||
+	    fsp->fh->fd == -1)
+	{
 		/*
 		 * fsp could be NULL here so use the value from the packet. JRA.
 		 */