From: Bruce Momjian <bruce@momjian.us>
Date: Mon, 29 Nov 2004 03:01:54 +0000 (+0000)
Subject: Add comment explaining possible compiler warning:
X-Git-Tag: REL8_0_0RC1~71
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=55481228299eee3cfb1ea5097ddd5558bea5382e;p=thirdparty%2Fpostgresql.git

Add comment explaining possible compiler warning:

    /*
     *  Some compilers with throw a warning knowing this test can never be
     *  true because off_t can't exceed the compared maximum.
     */
    if (th->fileLen > MAX_TAR_MEMBER_FILELEN)
        die_horribly(AH, modulename, "archive member too large for tar format\n");
---

diff --git a/src/bin/pg_dump/pg_backup_tar.c b/src/bin/pg_dump/pg_backup_tar.c
index 61eeb6d06db..97b5c3576e3 100644
--- a/src/bin/pg_dump/pg_backup_tar.c
+++ b/src/bin/pg_dump/pg_backup_tar.c
@@ -16,7 +16,7 @@
  *
  *
  * IDENTIFICATION
- *		$PostgreSQL: pgsql/src/bin/pg_dump/pg_backup_tar.c,v 1.45 2004/10/07 15:21:55 momjian Exp $
+ *		$PostgreSQL: pgsql/src/bin/pg_dump/pg_backup_tar.c,v 1.46 2004/11/29 03:01:54 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1019,6 +1019,10 @@ _tarAddFile(ArchiveHandle *AH, TAR_MEMBER *th)
 	 */
 	fseeko(tmp, 0, SEEK_END);
 	th->fileLen = ftello(tmp);
+	/*
+	 *	Some compilers with throw a warning knowing this test can never be
+	 *	true because off_t can't exceed the compared maximum.
+	 */
 	if (th->fileLen > MAX_TAR_MEMBER_FILELEN)
 		die_horribly(AH, modulename, "archive member too large for tar format\n");
 	fseeko(tmp, 0, SEEK_SET);